Comments on: A dirty Ruby

By: Paul Watson

Paul Watson — Thu, 11 May 2006 15:54:08 +0000

How fantastic. I took the above code and cut it down to just this:

if soapResponse.getNewTagsSinceResult.respond_to? "tag"
&nbsp;&nbsp;for tag_current in Array(soapResponse.getNewTagsSinceResult.tag)
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;tag = Tag.find_by_sync_id(tag_current.id) || Tag.new
&nbsp;&nbsp;&nbsp;&nbsp;tag.name = tag_current.name
&nbsp;&nbsp;&nbsp;&nbsp;tag.sync_id = tag_current.id
&nbsp;&nbsp;&nbsp;&nbsp;tag.save
&nbsp;&nbsp;end
end

Thanks Farrel.

By: Farrel Lifson

Farrel Lifson — Thu, 11 May 2006 12:41:51 +0000

I did some further experimenting and it seems it's recommended to use Array(object) instead of object.to_a.

By: Paul Watson

Paul Watson — Thu, 11 May 2006 12:17:36 +0000

Thank you for those two comments Farrel. The last one is especially interesting. I'll give the to_a trick a try.

By: Paul Watson

Paul Watson — Thu, 11 May 2006 10:54:08 +0000

How fantastic. I took the above code and cut it down to just this:
if soapResponse.getNewTagsSinceResult.respond_to? "tag"   for tag_current in Array(soapResponse.getNewTagsSinceResult.tag)       tag = Tag.find_by_sync_id(tag_current.id) || Tag.new     tag.name = tag_current.name     tag.sync_id = tag_current.id     tag.save   end end

Thanks Farrel.

By: Farrel Lifson

Farrel Lifson — Thu, 11 May 2006 07:41:51 +0000

I did some further experimenting and it seems it’s recommended to use Array(object) instead of object.to_a.

By: Paul Watson

Paul Watson — Thu, 11 May 2006 07:17:36 +0000

Thank you for those two comments Farrel. The last one is especially interesting. I’ll give the to_a trick a try.

By: Farrel Lifson

Farrel Lifson — Thu, 11 May 2006 01:07:49 +0000

Also if you really want to squeeze things down you can do this:

@tag = Tag.find_by_syn_id(tag.id) || Tag.new
@tag.name = tag.name
@tag.sync_id ||= tag.id
@tag.save

By: Farrel Lifson

Farrel Lifson — Thu, 11 May 2006 00:18:22 +0000

I haven't used WSDLDriver but doe the tag object respond to to_a? If so you can do the following:

if soapResponse.getNewTagsSinceResult.respond_to? "tag"
for tag in soapResponse.getNewTagsSinceResult.tag.to_a
@tag = Tag.find_by_sync_id(tag.id)
if (@tag)
@tag.name = tag.name
@tag.save
else
@tag = Tag.new
@tag.name = tag.name
@tag.sync_id = tag.id
@tag.save
end
end
end

Just a quick warning that currently all objects respond to to_a but this will soon be deprecated so for future versions it's better to check that the tag object class explicity implements to_a.

By: Farrel Lifson

Farrel Lifson — Wed, 10 May 2006 20:07:49 +0000

Also if you really want to squeeze things down you can do this:

@tag = Tag.find_by_syn_id(tag.id) || Tag.new
@tag.name = tag.name
@tag.sync_id ||= tag.id
@tag.save

By: Farrel Lifson

Farrel Lifson — Wed, 10 May 2006 19:18:22 +0000

I haven’t used WSDLDriver but doe the tag object respond to to_a? If so you can do the following:

if soapResponse.getNewTagsSinceResult.respond_to? “tag”
for tag in soapResponse.getNewTagsSinceResult.tag.to_a
@tag = Tag.find_by_sync_id(tag.id)
if (@tag)
@tag.name = tag.name
@tag.save
else
@tag = Tag.new
@tag.name = tag.name
@tag.sync_id = tag.id
@tag.save
end
end
end

Just a quick warning that currently all objects respond to to_a but this will soon be deprecated so for future versions it’s better to check that the tag object class explicity implements to_a.